Implemented proper fall-back to ibv_post_send without whitelists #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Akhmedzhanov <[email protected]>
src/perftest_resources.c
Outdated
| @@ -1579,6 +1556,9 @@ int ctx_init(struct pingpong_context *ctx, struct perftest_parameters *user_para | |||
| for (i=0; i < user_param->num_of_qps; i++) { | |||
| if (create_qp_main(ctx, user_param, i, num_of_qps)) { | |||
| fprintf(stderr, "Failed to create QP.\n"); | |||
| if (user_param->connection_type == DC) { | |||
| fprintf(stderr, "DC is not supported for the divice chosen.\n"); | |||
There was a problem hiding this comment.
Is this related to the patch? Also there's a typo in device.
There was a problem hiding this comment.
Is this related to the patch? Also there's a typo in device.
Yes, it is, because the reason of failure of DC QP creation is fact that only new API supports DC.
| fprintf(stderr, "Unable to create QP.\n"); | ||
| return FAILURE; | ||
| } | ||
| return FAILURE; |
There was a problem hiding this comment.
Same question, is this related?
There was a problem hiding this comment.
Same question, is this related?
Yes, it is, because we don't want to print this in fall-back case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.